-
Notifications
You must be signed in to change notification settings - Fork 147
mcux-sdk-ng/driver: Roll back the cache64 driver version #527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
mcux-sdk-ng/driver: Roll back the cache64 driver version #527
Conversation
After updating the hal_nxp driver to SDK 25.03.00 release, the cache64 driver will cause the MCXN947 flash test cases to fail on the zephyr side. Signed-off-by: Zhaoxiang Jin <Zhaoxiang.Jin_1@nxp.com>
|
@@ -70,7 +70,7 @@ extern "C" { | |||
|
|||
#if (defined(FSL_FEATURE_SOC_CACHE64_POLSEL_COUNT) && (FSL_FEATURE_SOC_CACHE64_POLSEL_COUNT > 0)) | |||
/*! | |||
* @brief Returns an instance number given peripheral base address. | |||
* @brief Returns an instance number given periphearl base address. | |||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
peripheral is not typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i just rolled back the driver to version 2.0.8
For this issue, we need to first fix it in hal_nxp, then request internal developers to update the driver in the SDK and run downstream tests to ensure compatibility with Zephyr. The updated driver will be updated to hal_nxp after the next SDK release. |
Can we have the quick fix (just revert) in the Upstream Zephyr, to unblock MCXN947? |
yes, current PR is a simple revert. |
Is this change being incorporated in the source SDK-NG? |
No, I just revert the driver to a old version to eliminate regression issues caused by adopting SDK-NG to hal_nxp. The internal CACHE driver developer will update the driver to satisfy both SDK and zephyr, the updated driver can be synced to hal_nxp after the next SDK release. |
Can we directly use the SDK patch for this issue? then we can make sure the SDK patch really fixed this issue, thanks. @ZhaoxiangJin @Albort12138 |
Hi @zejiang0jason, to fix this issue, we still depend on a patch from device's header. |
Zephyr does not urgently need the SDK patch. We currently need a way to test the SDK patch in zephyr downstream. |
After updating the hal_nxp driver to SDK 25.03.00 release, the cache64 driver will cause the MCXN947 flash test cases to fail on the zephyr side.